Several problems

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Several problems

aardvark (Bugzilla)
Hi,

First off, your web page never really says what to do with bugs.  It
trails off with this email address.  So, if bugs aren't to be sent here,
fix the page.  If so, make it a little clearer.

Are you not using the sourceforge bug tracking system?  If not, there
are 9 bugs being ignored (I noticed that all of them are unassigned).

Secondly, I've had it crash consistently when trying to use autotrace.
The following patch fixes (or, at least works around) the problem
(sc->parent is NULL):

--- splineutil.c.~1.56.~ 2005-05-03 11:28:01.000000000 -0400
+++ splineutil.c 2005-05-14 18:22:15.000000000 -0400
@@ -701,7 +701,7 @@
  _SplineSetFindBounds(sc->layers[i].splines,bounds);
 #endif
     }
-    if ( sc->parent->strokedfont && (bounds->minx!=bounds->maxx || bounds->miny!=bounds->maxy)) {
+    if ( sc->parent && sc->parent->strokedfont && (bounds->minx!=bounds->maxx || bounds->miny!=bounds->maxy)) {
  real sw = sc->parent->strokewidth;
  bounds->minx -= sw; bounds->miny -= sw;
  bounds->maxx += sw; bounds->maxy += sw;

Third, it looks like your error handling is broken.

Recovering from /home/aardvark/.PfaEdit/autosave/auto007639-14.asfd... Internal Error:
Invalid 2nd order spline in SplineRefigure2
Internal Error:
Invalid 2nd order spline in SplineRefigure2

Program received signal SIGINT, Interrupt.
0xb7fe87a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
(gdb) bt
#0  0xb7fe87a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#1  0xb7bbaa1d in ___newselect_nocancel () from /lib/tls/libc.so.6
#2  0xb7fd110c in GXDrawWaitForEvent (gdisp=0x84d1c58) at gxdraw.c:2661
#3  0xb7fd3534 in GXDrawProcessOneEvent (gdisp=0x84d1c58) at gxdraw.c:3123
#4  0xb7f8d268 in GDrawProcessOneEvent (gdisp=0xbfffa800) at gdraw.c:600
#5  0xb7f8da5a in RunError () at gdrawerror.c:80
#6  0xb7f8dd63 in GDrawIError (fmt=0x826528c "%s") at gdrawerror.c:157
#7  0x0815de53 in IError (
    format=0x82a1b44 "Invalid 2nd order spline in SplineRefigure2")
    at uiutil.c:474
#8  0x081d3105 in SplineRefigure2 (spline=0x8615338) at splineorder2.c:805
#9  0x081d317c in SplineMake2 (from=0x860e7b0, to=0x860e7dc)
    at splineorder2.c:1023
#10 0x0810cadc in SFDGetSplineSet (sf=0x84e4bf0, sfd=0x854db40) at sfd.c:2104
#11 0x0810d99f in SFDGetChar (sfd=0x854db40, sf=0x84e4bf0) at sfd.c:2632
#12 0x0810fc40 in SFD_GetFont (sfd=0x854db40, cidmaster=0x0,
    tok=0xbfffc8c0 "BeginChars:") at sfd.c:4399
#13 0x081145a1 in SFDRead (
    filename=0xbfffe410 "/home/aardvark/fonts/uncial/Uncial.sfd") at sfd.c:4458
#14 0x080c3bf4 in ReadSplineFont (
    filename=0xbfffe410 "/home/aardvark/fonts/uncial/Uncial.sfd", openflags=0)
    at fontview.c:9159
#15 0x080c459c in LoadSplineFont (
    filename=0xbfffe410 "/home/aardvark/fonts/uncial/Uncial.sfd", openflags=0)
    at fontview.c:9388
#16 0x08114a8c in SFRecoverFile (
    autosavename=0xbfffe860 "/home/aardvark/.PfaEdit/autosave/auto007639-14.asfd") at sfd.c:4626
#17 0x08057d8d in DoAutoRecovery () at autosave.c:140
#18 0x0814cbe2 in main (argc=1, argv=0xbffff6f4) at start.c:682

One popup box appears with the message, I clicked OK.  No other box shows up.
The recover box is frozen halfway through the recovery.

Which brings up the proposal that fontforge should be more robust about
spline errors.  After putting up the "Invalid spline" box several times in
a row with no option other than to keep clicking OK, all one can do is kill
the program.  (See bug 1086756 on sourceforge.)

-d



-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
Fontforge-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/fontforge-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Several problems

George Williams
On Tue, 2005-05-17 at 13:31, Don Koch wrote:
> Are you not using the sourceforge bug tracking system?  If not, there
> are 9 bugs being ignored (I noticed that all of them are unassigned).
No.
>
> Secondly, I've had it crash consistently when trying to use autotrace.
> The following patch fixes (or, at least works around) the problem
> (sc->parent is NULL):
sc->parent should never be NULL.
Please tell me what you do to generate the crash.

> Third, it looks like your error handling is broken.
>
> Recovering from /home/aardvark/.PfaEdit/autosave/auto007639-14.asfd... Internal Error:
> Invalid 2nd order spline in SplineRefigure2
> Internal Error:
> Invalid 2nd order spline in SplineRefigure2
Please tell me what you do to generate this error. Send me the font and
the error recovery file (found in ~/.PfaEdit/autosave)



-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
Fontforge-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/fontforge-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Several problems

aardvark (Bugzilla)
On Tue, 2005-05-17 at 13:31, Don Koch wrote:
>> Are you not using the sourceforge bug tracking system?  If not, there
>> are 9 bugs being ignored (I noticed that all of them are unassigned).

[hidden email] said:
> No.

I'd suggest having them turn it off or something.  You have users thinking
you're ignoring them.

>> Secondly, I've had it crash consistently when trying to use autotrace.
>> The following patch fixes (or, at least works around) the problem
>> (sc->parent is NULL):

> sc->parent should never be NULL.
> Please tell me what you do to generate the crash.

As I recall, I was doing an Autotrace using autotrace.  Consistently.
I've stopped using autotrace as it took more work to clean it up than
to do it by hand from scratch.  It's probably better on cleaner images,
but one would have to clean up the original images.

>> Third, it looks like your error handling is broken.
>>
>> Recovering from /home/aardvark/.PfaEdit/autosave/auto007639-14.asfd... Internal Error:
>> Invalid 2nd order spline in SplineRefigure2
>> Internal Error:
>> Invalid 2nd order spline in SplineRefigure2

> Please tell me what you do to generate this error. Send me the font and the
> error recovery file (found in ~/.PfaEdit/autosave)

Just moving points around will sometimes generate this.  Sorry, but I
already deleted the file in the autosave directory.  It was generating
NaN's and not handling them.  Ugly workaround in SolveCubicBack() follows:

--- splineutil.c.~1.56.~        2005-05-03 11:28:01.000000000 -0400
+++ splineutil.c        2005-05-21 15:20:05.000000000 -0400
@@ -399,6 +399,9 @@
     double t, val, offset;
     int first;
 
+    if ( isnan(a) | isnan(b) | isnan(c) | isnan(d) )
+      return 0.5;              /* for now... */
+
     offset=a;
     if ( a<0 ) offset = -a;
     if ( b<0 ) offset -= b; else offset += b;

BTW, it would be nice if it at least indicated which character it was
complaining about (as someone reported on sourceforge in the bugs you
are ignoring).  Better yet, indicate the offending spline.


Yet another problem I've run into is that it likes to generate corner
points on occasion when I've told it to generate curve points.  The point
menu has curve checked.  Only one control is grabbable.  Changing the
point type doesn't do anything.  And, no, the other control point wasn't
sitting on the curve point; I had two adjacent points like this where
the control points were away from the other curve point (as if I had
two corner points with a strait line between them).

-d




-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
Fontforge-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/fontforge-devel
Loading...